Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes: > The is-closed flag may be added after we have acquired the vma under the You talk about flag but it is a place in a closed_vma list. Well for outside observer i guess it is a flag. > ctx->mutex, but will not take effect until after we release the > vm->mutex. i.e. the flag may be set on the vma as attempt to bind it and Take effect? We need vm lock to actually clear the closed_vma list so yes. > that will cause the vma to be unbound later after we unpin it. I am still trying to find the call path that would reinsert a closed one with vm lock still held.. -Mika > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_vma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c > index 298ca4316e65..3dde671145f7 100644 > --- a/drivers/gpu/drm/i915/i915_vma.c > +++ b/drivers/gpu/drm/i915/i915_vma.c > @@ -641,7 +641,6 @@ i915_vma_insert(struct i915_vma *vma, u64 size, u64 alignment, u64 flags) > u64 start, end; > int ret; > > - GEM_BUG_ON(i915_vma_is_closed(vma)); > GEM_BUG_ON(i915_vma_is_bound(vma, I915_VMA_GLOBAL_BIND | I915_VMA_LOCAL_BIND)); > GEM_BUG_ON(drm_mm_node_allocated(&vma->node)); > > -- > 2.25.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
