Hi Chris, On Thu, Feb 27, 2020 at 08:57:11AM +0000, Chris Wilson wrote: > Still chasing the mystery of the stray idle flush, let's ensure that the > heartbeat does not run at the same time as our test and confuse us. > > References: https://gitlab.freedesktop.org/drm/intel/issues/541 > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> [...] > @@ -331,8 +331,7 @@ void i915_active_unlock_wait(struct i915_active *ref) > } > > /* And wait for the retire callback */ > - spin_lock_irq(&ref->tree_lock); > - spin_unlock_irq(&ref->tree_lock); > + spin_unlock_wait(&ref->tree_lock); maybe one day I will stop complaining about out of context changes... maybe one day. Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxx> Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx