On Tue, 25 Feb 2020, Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> wrote: > Quoting Jani Nikula (2020-02-25 13:07:28) >> The #include has been splattered all over the place, but there are >> precious few places, all .c files, that actually need it. >> >> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> > > Trust in the compiler, > Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> Thanks! > The users of i915_drv.h that irk me the most are where we only want the > device_info/runtime_info. Might just bite the bullet and make those > pointers and so not have to traverse through i915. In general, struct drm_i915_private is just way too big. It requires the definitions of almost everything, and almost everything needs struct drm_i915_private definition. Static inlines that look inside i915 make matters worse. BR, Jani. -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
