== Series Details == Series: drm/i915/gt: make a gt sysfs group and move power management files (rev5) URL : https://patchwork.freedesktop.org/series/73190/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1ad40388b0d2 drm/i915/gt: make a gt sysfs group and move power management files -:88: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #88: new file mode 100644 -:164: WARNING:TYPO_SPELLING: 'wether' may be misspelled - perhaps 'whether'? #164: FILE: drivers/gpu/drm/i915/gt/sysfs_gt.c:72: + * the name gt tells us wether sysfs_root -:567: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'gt_rp_mhz_show' to 'gt_RP0_freq_mhz_show' #567: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:362: +static DEVICE_ATTR(gt_RP0_freq_mhz, 0444, gt_rp_mhz_show, NULL); -:568: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'gt_rp_mhz_show' to 'gt_RP1_freq_mhz_show' #568: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:363: +static DEVICE_ATTR(gt_RP1_freq_mhz, 0444, gt_rp_mhz_show, NULL); -:569: CHECK:CAMELCASE: Avoid CamelCase: <gt_RPn_freq_mhz> #569: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:364: +static DEVICE_ATTR(gt_RPn_freq_mhz, 0444, gt_rp_mhz_show, NULL); -:569: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'gt_rp_mhz_show' to 'gt_RPn_freq_mhz_show' #569: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:364: +static DEVICE_ATTR(gt_RPn_freq_mhz, 0444, gt_rp_mhz_show, NULL); -:584: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_gt_RPn_freq_mhz> #584: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:379: + else if (attr == &dev_attr_gt_RPn_freq_mhz) -:587: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #587: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:382: + BUG(); total: 0 errors, 6 warnings, 2 checks, 1009 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
