== Series Details == Series: series starting with [CI,01/10] drm/i915/debugfs: Pass guc_log struct to i915_guc_log_info URL : https://patchwork.freedesktop.org/series/73610/ State : warning == Summary == $ dim checkpatch origin/drm-tip c9413e3a8cde drm/i915/debugfs: Pass guc_log struct to i915_guc_log_info a6ea555cb6b1 drm/i915/guc: Kill USES_GUC macro 38db7bd09a6d drm/i915/guc: Kill USES_GUC_SUBMISSION macro 22e4c362bb86 drm/i915/uc: Update the FW status on injected fetch error ca3c50fa47ed drm/i915/uc: autogenerate uC checker functions -:32: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #32: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:43: +#define __uc_state_checker(x, state, required) \ +static inline bool intel_uc_##state##_##x(struct intel_uc *uc) \ +{ \ + return intel_##x##_is_##required(&uc->x); \ } -:42: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #42: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:49: +#define uc_state_checkers(x) \ +__uc_state_checker(x, supports, supported) \ +__uc_state_checker(x, uses, enabled) -:42: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #42: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:49: +#define uc_state_checkers(x) \ +__uc_state_checker(x, supports, supported) \ +__uc_state_checker(x, uses, enabled) total: 1 errors, 0 warnings, 2 checks, 44 lines checked cd5541c40e50 drm/i915/uc: Improve tracking of uC init status 0d79221ea12e drm/i915/guc: Apply new uC status tracking to GuC submission as well -:247: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #247: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:65: +#define __uc_state_checker(x, func, state, required) \ +static inline bool intel_uc_##state##_##func(struct intel_uc *uc) \ { \ + return intel_##func##_is_##required(&uc->x); \ } -:258: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #258: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:71: +#define uc_state_checkers(x, func) \ +__uc_state_checker(x, func, supports, supported) \ +__uc_state_checker(x, func, wants, wanted) \ +__uc_state_checker(x, func, uses, used) -:258: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #258: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:71: +#define uc_state_checkers(x, func) \ +__uc_state_checker(x, func, supports, supported) \ +__uc_state_checker(x, func, wants, wanted) \ +__uc_state_checker(x, func, uses, used) -:258: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects? #258: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:71: +#define uc_state_checkers(x, func) \ +__uc_state_checker(x, func, supports, supported) \ +__uc_state_checker(x, func, wants, wanted) \ +__uc_state_checker(x, func, uses, used) total: 1 errors, 0 warnings, 3 checks, 250 lines checked 65d24a2b9584 drm/i915/uc: Abort early on uc_init failure ff1adf98f8d4 drm/i915/uc: consolidate firmware cleanup 50bb392a051d HAX: drm/i915: default to enable_guc=2 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
