== Series Details == Series: drm/i915/gt: make a gt sysfs group and move power management files (rev3) URL : https://patchwork.freedesktop.org/series/73190/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2bb6ef6acc00 drm/i915/gt: make a gt sysfs group and move power management files -:71: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? #71: new file mode 100644 -:553: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'gt_rp_mhz_show' to 'gt_RP0_freq_mhz_show' #553: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:359: +static DEVICE_ATTR(gt_RP0_freq_mhz, 0444, gt_rp_mhz_show, NULL); -:554: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'gt_rp_mhz_show' to 'gt_RP1_freq_mhz_show' #554: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:360: +static DEVICE_ATTR(gt_RP1_freq_mhz, 0444, gt_rp_mhz_show, NULL); -:555: CHECK:CAMELCASE: Avoid CamelCase: <gt_RPn_freq_mhz> #555: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:361: +static DEVICE_ATTR(gt_RPn_freq_mhz, 0444, gt_rp_mhz_show, NULL); -:555: WARNING:DEVICE_ATTR_FUNCTIONS: Consider renaming function(s) 'gt_rp_mhz_show' to 'gt_RPn_freq_mhz_show' #555: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:361: +static DEVICE_ATTR(gt_RPn_freq_mhz, 0444, gt_rp_mhz_show, NULL); -:570: CHECK:CAMELCASE: Avoid CamelCase: <dev_attr_gt_RPn_freq_mhz> #570: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:376: + else if (attr == &dev_attr_gt_RPn_freq_mhz) -:573: WARNING:AVOID_BUG: Avoid crashing the kernel - try using WARN_ON & recovery code rather than BUG() or BUG_ON() #573: FILE: drivers/gpu/drm/i915/gt/sysfs_gt_pm.c:379: + BUG(); total: 0 errors, 5 warnings, 2 checks, 1029 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
