Re: [PATCH 2/2] drm/i915: switch vlv_suspend to use intel uncore register accessors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Jani Nikula (2020-02-12 14:40:58)
> Prefer intel_uncore_* over I915_READ, I915_WRITE, and POSTING_READ.
> 
> Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx>

A couple of older checkpatch errors that could be cleaned up (pure
whitespacing).

Both
Reviewed-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>

Half this code should be removed as we explicitly reset the registers on
resume. (And if we need to add a few special runtime-resume hooks, would
not be a bad thing). And the other half, probably should be removed with
a bit of extra work.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux