On 2/11/20 5:47 PM, Andi Shyti wrote:
Hi Daniele,+ if (intel_uc_uses_huc(uc)) { + ret = intel_huc_init(huc);are we ever going to call intel_huc_init() if !intel_uc_uses_huc()? if not, why don't check intel_uc_uses_huc() inside intel_huc_init()? just to avoid always the double "if".
I'm actually plotting another refactoring of the init/fini flows as I don't like how we toggle the FW states at the moment. I can bundle this change with that.
Daniele
Not a big deal though: Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxx> Andi
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
