On 2020-02-11 at 18:26:13 +0200, Ville Syrjälä wrote:
> On Tue, Feb 11, 2020 at 09:39:37PM +0530, Anshuman Gupta wrote:
> > On 2020-02-07 at 18:15:31 +0200, Ville Syrjälä wrote:
> > > On Fri, Feb 07, 2020 at 07:50:36PM +0530, Anshuman Gupta wrote:
> > > > Updated version after rebase and fixing few comments.
> > > >
> > > > Anshuman Gupta (6):
> > > > drm/i915: Iterate over pipe and skip the disabled one
> > > > drm/i915: Remove (pipe == crtc->index) assumption
> > > > drm/i915: Fix broken transcoder err state
> > > > drm/i915: Fix wrongly populated plane possible_crtcs bit mask
> > > > drm/i915: Get right max plane stride
> > > > drm/i915: Add WARN_ON in intel_get_crtc_for_pipe()
> > >
> > > Another broken thing I realized recently is due to my
> > > commit ee34801cc0e8 ("drm/i915: Prefer to use the pipe to index the ddb
> > > entries")
> > >
> > > We either need to revert that or always pass s/num_pipes/I915_MAX_PIPES/
> > > to skl_ddb_allocation_overlaps() in skl_commit_modeset_enables().
> > > The latter may be nicer since I don't really want that silly 'i'
> > > usage back. Can you cook up a patch like that as well?
> > AFAIU entries[] may have holes inside it as its size is I915_MAX_PIPES,
> > though these holes are already initialized with zero and will not harm
> > skl_ddb_allocation_overlaps, is it good a idea to avoid these hole
> > as ignore_index bit mask ?
>
> skl_ddb_entries_overlap() should just ignore empty allocations.
> And that will anyway happen for any pipe that is not active. So we
> don't have to worry about any holes.
Thanks Ville for explanation.
Thanks,
Anshuman Gupta.
>
> --
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
