On Tue, Feb 11, 2020 at 11:37:32AM +0200, Petri Latvala wrote: > On Tue, Feb 11, 2020 at 11:30:03AM +0200, Jani Nikula wrote: > > On Tue, 11 Feb 2020, Petri Latvala <petri.latvala@xxxxxxxxx> wrote: > > >> diff --git a/lib/i915/gem_mmio_base.c b/lib/i915/gem_mmio_base.c > > >> new file mode 100644 > > >> index 000000000..8718c092f > > >> --- /dev/null > > >> +++ b/lib/i915/gem_mmio_base.c > > >> @@ -0,0 +1,346 @@ > > >> +// Copyright (C) 2020 Intel Corporation > > >> +// > > >> +// SPDX-License-Identifier: MIT > > > > > > We don't use SPDX headers in IGT, please use the MIT license comment > > > block instead. > > > > Why not? Should we start? > > I'm all for it, but preferably not trickled in but as separate conversion! I have been informed from people with experience that converting to SPDX is more convoluted than I thought. Thus, take-backsies! SPDX for new files is ok. You can quote me on this. -- Petri Latvala _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx