Hi Chris, > > "We don't own the debugfs 'namespace' prefix." (Jani Nikula [*]) > > > > I agree, change the functions name from "debugfs_*" to > > "intel_gt_*" prefix. > > An alternate way of looking at it is that these are all dependent on > CONFIG_DEBUGFS. So are they not the debugfs interface? this is a complete matter of taste, I might have a strong opinion if the concept of name prefix was something respected all over i915, but that's not always the case. If Jani feels like enforcing the idea of the function name prefix, I basically agree with the style. With "debugfs_*" I understand all those functions that handle the debugfs as framework. Andi _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx