== Series Details == Series: Commit early to GuC (rev2) URL : https://patchwork.freedesktop.org/series/72031/ State : warning == Summary == $ dim checkpatch origin/drm-tip e5cb7d5a536e drm/i915/debugfs: Pass guc_log struct to i915_guc_log_info ebe1197848d5 drm/i915/guc: Kill USES_GUC macro 2243201c583e drm/i915/guc: Kill USES_GUC_SUBMISSION macro f0481b5c0bfb drm/i915/uc: Update the FW status on injected fetch error 0cecb99111fb drm/i915/uc: autogenerate uC checker functions -:31: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #31: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:43: +#define __uc_state_checker(x, state, required) \ +static inline bool intel_uc_##state##_##x(struct intel_uc *uc) \ +{ \ + return intel_##x##_is_##required(&uc->x); \ } -:41: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #41: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:49: +#define uc_state_checkers(x) \ +__uc_state_checker(x, supports, supported) \ +__uc_state_checker(x, uses, enabled) -:41: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #41: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:49: +#define uc_state_checkers(x) \ +__uc_state_checker(x, supports, supported) \ +__uc_state_checker(x, uses, enabled) total: 1 errors, 0 warnings, 2 checks, 44 lines checked a5eb1097207f drm/i915/uc: Improve tracking of uC init status 0cd48e992b8b drm/i915/guc: Apply new uC status tracking to GuC submission as well -:212: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #212: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:64: +#define __uc_state_checker(x, func, state, required) \ +static inline bool intel_uc_##state##_##func(struct intel_uc *uc) \ { \ + return intel_##func##_is_##required(&uc->x); \ } -:223: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #223: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:70: +#define uc_state_checkers(x, func) \ +__uc_state_checker(x, func, supports, supported) \ +__uc_state_checker(x, func, wants, wanted) \ +__uc_state_checker(x, func, uses, used) -:223: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #223: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:70: +#define uc_state_checkers(x, func) \ +__uc_state_checker(x, func, supports, supported) \ +__uc_state_checker(x, func, wants, wanted) \ +__uc_state_checker(x, func, uses, used) -:223: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects? #223: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:70: +#define uc_state_checkers(x, func) \ +__uc_state_checker(x, func, supports, supported) \ +__uc_state_checker(x, func, wants, wanted) \ +__uc_state_checker(x, func, uses, used) total: 1 errors, 0 warnings, 3 checks, 225 lines checked 61eee547ff65 drm/i915/uc: Abort early on uc_init failure 1d318ae28200 drm/i915/uc: consolidate firmware cleanup e4ad6a295fb1 HAX: drm/i915: default to enable_guc=2 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
