On Wed, Aug 29, 2012 at 03:12:37PM +0100, Simon Farnsworth wrote: > On Wednesday 29 August 2012 16:43:58 Jani Nikula wrote: > > The sdvo hotplug support check and activation has worked by coincidence for > > TMDS0. The boolean value returned by intel_sdvo_supports_hotplug() was > > masked with a bit shifted by device number, which also should have been one > > of SDVO_OUTPUT_* bits instead. Boolean true masked with 1 shifted by 0 just > > happened to match SDVO_OUTPUT_TMDS0... > > > > Get hotplug support as a bit mask, check the correct bits for support, and > > use the correct bits for activating hotplug support. > > > > Signed-off-by: Jani Nikula <jani.nikula at intel.com> > > > Reviewed-by: Simon Farnsworth <simon.farnsworth at onelan.com> Queued for -next (together with a duplicate of the bugfix to avoid merge hassles), thanks for the patch. -Daniel > > The code you're fixing was written with the aid of ajax's educated guesses - > it's nice to see an Intel employee fix it to match the spec. > -- > Simon Farnsworth > Software Engineer > ONELAN Ltd > http://www.onelan.com -- Daniel Vetter Mail: daniel at ffwll.ch Mobile: +41 (0)79 365 57 48
