(apologies to Daniel and Jani, who've seen this twice - I accidentally sent it from the wrong address originally). On Wednesday 29 August 2012 16:43:58 Jani Nikula wrote: > The sdvo hotplug support check and activation has worked by coincidence for > TMDS0. The boolean value returned by intel_sdvo_supports_hotplug() was > masked with a bit shifted by device number, which also should have been one > of SDVO_OUTPUT_* bits instead. Boolean true masked with 1 shifted by 0 just > happened to match SDVO_OUTPUT_TMDS0... > > Get hotplug support as a bit mask, check the correct bits for support, and > use the correct bits for activating hotplug support. > > Signed-off-by: Jani Nikula <jani.nikula at intel.com> > Reviewed-by: Simon Farnsworth <simon.farnsworth at onelan.com> The code you're fixing was written with the aid of ajax's educated guesses - it's nice to see an Intel employee fix it to match the spec. -- Simon Farnsworth Software Engineer ONELAN Ltd http://www.onelan.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 490 bytes Desc: This is a digitally signed message part. URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20120829/8575d165/attachment.pgp>
