On Tue, 28 Jan 2020, Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@xxxxxxxxx> wrote: > Device specific dev_WARN and dev_WARN_ONCE macros available in kernel > include device information in the backtrace, so we know what device > the warnings originate from. > > Similar to this, add new struct drm_device based drm_WARN* macros. These > macros include device information in the backtrace, so we know > what device the warnings originate from. Knowing the device specific > information in the backtrace would be helpful in development all > around. > > This patch series aims to convert calls of WARN(), WARN_ON(), > WARN_ONCE() and WARN_ON_ONCE() in i915 driver to use the drm > device-specific variants automatically wherever struct device pointer > is available. > > To do this, this patch series - > - introduces new struct drm_device based WARN* macros > - automatically converts WARN* with device specific dev_WARN* > variants using coccinelle semantic patch scripts. > > The goal is to convert all the calls of WARN* with drm_WARN* in i915, > but there are still cases where device pointer is not readily > available in some functions (or I missed them somehow) using WARN* > hence some manual churning is needed. Handle such remaining cases > separately later. Thanks for the patches, pushed all that applied, please rebase the rest. BR, Jani. > > changes since v4: > - Address Jani's comment > - split major i915/display related conversions per file into > seperate patches so that non conflicting patches can be > merged. > > changes since v3: > - rebase pending unmerged patches on drm-tip > (bc626bbb5b6e drm-tip: 2020y-01m-25d-14h-28m-41s UTC integration manifest) > > changes since v2: > - rebase pending unmerged patches on drm-tip > > changes since v1: > - Address Jani's review comments > - Fix typo in comment of patch 0001 > - Get rid of helper functions > - Split patches by directory > > Changes since RFC at [1] > - Introduce drm_WARN* macros and use them as suggested by Sam and Jani > - Get rid of extra local variables > > [1] https://patchwork.freedesktop.org/series/71668/ > > > Pankaj Bharadiya (21): > drm/i915/display/icl_dsi: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/audio: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/cdclk: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/crt: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/ddi: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/display: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/power: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/dp: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/dpll_mgr: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/fbc: Make WARN* drm specific where drm_priv ptr is available > drm/i915/fbdev: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/hdcp: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/hdmi: Make WARN* drm specific where drm_device ptr is available > drm/i915/display/overlay: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/panel: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/psr: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/sdvo: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display/tc: Make WARN* drm specific where drm_priv ptr is available > drm/i915/display: Make WARN* drm specific where drm_device ptr is available > drm/i915/gvt: Make WARN* drm specific where drm_priv ptr is available > drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available > > drivers/gpu/drm/i915/display/icl_dsi.c | 14 +- > drivers/gpu/drm/i915/display/intel_atomic.c | 6 +- > drivers/gpu/drm/i915/display/intel_audio.c | 19 +- > drivers/gpu/drm/i915/display/intel_bios.c | 10 +- > drivers/gpu/drm/i915/display/intel_bw.c | 3 +- > drivers/gpu/drm/i915/display/intel_cdclk.c | 81 ++++--- > drivers/gpu/drm/i915/display/intel_color.c | 3 +- > .../gpu/drm/i915/display/intel_combo_phy.c | 2 +- > .../gpu/drm/i915/display/intel_connector.c | 3 +- > drivers/gpu/drm/i915/display/intel_crt.c | 10 +- > drivers/gpu/drm/i915/display/intel_ddi.c | 92 +++---- > drivers/gpu/drm/i915/display/intel_display.c | 226 ++++++++++-------- > .../drm/i915/display/intel_display_power.c | 168 +++++++------ > drivers/gpu/drm/i915/display/intel_dp.c | 117 +++++---- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 10 +- > drivers/gpu/drm/i915/display/intel_dpio_phy.c | 3 +- > drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 37 +-- > drivers/gpu/drm/i915/display/intel_dsb.c | 6 +- > .../i915/display/intel_dsi_dcs_backlight.c | 2 +- > drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 5 +- > drivers/gpu/drm/i915/display/intel_fbc.c | 23 +- > drivers/gpu/drm/i915/display/intel_fbdev.c | 13 +- > drivers/gpu/drm/i915/display/intel_gmbus.c | 3 +- > drivers/gpu/drm/i915/display/intel_hdcp.c | 21 +- > drivers/gpu/drm/i915/display/intel_hdmi.c | 52 ++-- > drivers/gpu/drm/i915/display/intel_hotplug.c | 7 +- > .../gpu/drm/i915/display/intel_lpe_audio.c | 2 +- > drivers/gpu/drm/i915/display/intel_lvds.c | 7 +- > drivers/gpu/drm/i915/display/intel_opregion.c | 7 +- > drivers/gpu/drm/i915/display/intel_overlay.c | 12 +- > drivers/gpu/drm/i915/display/intel_panel.c | 19 +- > drivers/gpu/drm/i915/display/intel_pipe_crc.c | 7 +- > drivers/gpu/drm/i915/display/intel_psr.c | 32 +-- > drivers/gpu/drm/i915/display/intel_sdvo.c | 14 +- > drivers/gpu/drm/i915/display/intel_sprite.c | 5 +- > drivers/gpu/drm/i915/display/intel_tc.c | 18 +- > drivers/gpu/drm/i915/display/intel_vdsc.c | 2 +- > drivers/gpu/drm/i915/display/vlv_dsi.c | 2 +- > drivers/gpu/drm/i915/gvt/aperture_gm.c | 6 +- > drivers/gpu/drm/i915/gvt/cfg_space.c | 23 +- > drivers/gpu/drm/i915/gvt/cmd_parser.c | 4 +- > drivers/gpu/drm/i915/gvt/display.c | 6 +- > drivers/gpu/drm/i915/gvt/dmabuf.c | 4 +- > drivers/gpu/drm/i915/gvt/edid.c | 19 +- > drivers/gpu/drm/i915/gvt/gtt.c | 21 +- > drivers/gpu/drm/i915/gvt/gvt.c | 4 +- > drivers/gpu/drm/i915/gvt/handlers.c | 22 +- > drivers/gpu/drm/i915/gvt/interrupt.c | 16 +- > drivers/gpu/drm/i915/gvt/kvmgt.c | 10 +- > drivers/gpu/drm/i915/gvt/mmio.c | 30 ++- > drivers/gpu/drm/i915/gvt/mmio_context.c | 8 +- > drivers/gpu/drm/i915/gvt/scheduler.c | 6 +- > drivers/gpu/drm/i915/gvt/vgpu.c | 6 +- > 53 files changed, 716 insertions(+), 532 deletions(-) -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
