Re: [PATCH i-g-t] i915/gem_exec_basic: Drop per-engine testing of *execbuf

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Antonio Argenziano (2020-02-03 22:15:26)
> 
> 
> On 03/02/20 13:45, Chris Wilson wrote:
> > @@ -121,30 +43,29 @@ igt_main
> >   
> >       igt_fixture {
> >               fd = drm_open_driver(DRIVER_INTEL);
> > -             igt_require_gem(fd);
> > -
> > +             /* igt_require_gem(fd); // test is mandatory */
> 
> What if that fd is bad? Assert?

fd can't be bad, that's taken care of by drm_open_driver(). If the
driver is unusable for execbuf, we want the test failure. It's a choice.

Not sure the right answer, both have advantages.

> > +static void mmapped(int i915)
> > +{
> > +     struct drm_i915_gem_execbuffer2 *execbuf;
> > +     struct drm_i915_gem_exec_object2 *exec;
> > +     uint32_t handle;
> 
> gem_require_mappable_ggtt()?

No... I was dropping a hint in the name. How's the toolbox?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux