Quoting Matthew Auld (2020-02-03 17:32:29) > On 03/02/2020 09:41, Chris Wilson wrote: > > + for (i = 0; i < ARRAY_SIZE(rq); i++) { > > + rq[i] = i915_request_create(ce); > > + if (IS_ERR(rq[i])) { > > + err = PTR_ERR(rq[i]); > > + goto out; > > + } > > + ... > > +out: > > + for (i = 0; i < ARRAY_SIZE(rq); i++) > > + i915_request_put(rq[i]); > > !IS_ERR_OR_NULL()? Oh drat, I let err into rq[]. I'll rework the assignment to avoid putting the ERR_PTR here. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx