> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Jani > Nikula > Sent: Tuesday, January 28, 2020 9:59 PM > To: intel-gfx@xxxxxxxxxxxxxxxxxxxxx > Cc: Nikula, Jani <jani.nikula@xxxxxxxxx> > Subject: [PATCH 3/3] drm/i915: move intel_dp_set_m_n() to encoder > for DDI platforms > > intel_dp_set_m_n() has a clear place in the DDI DP specific pre-enable hook. > > Cc: Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> Looks good to me. Reviewed-by: Vandita Kulkarni <vandita.kulkarni@xxxxxxxxx> -Regards, Vandita > --- > drivers/gpu/drm/i915/display/intel_ddi.c | 2 ++ > drivers/gpu/drm/i915/display/intel_display.c | 3 --- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c > b/drivers/gpu/drm/i915/display/intel_ddi.c > index 5febd3a911fe..2a773ab7ace9 100644 > --- a/drivers/gpu/drm/i915/display/intel_ddi.c > +++ b/drivers/gpu/drm/i915/display/intel_ddi.c > @@ -3573,6 +3573,8 @@ static void intel_ddi_pre_enable_dp(struct > intel_encoder *encoder, > */ > if (!intel_crtc_has_type(crtc_state, INTEL_OUTPUT_DP_MST)) > intel_ddi_set_dp_msa(crtc_state, conn_state); > + > + intel_dp_set_m_n(crtc_state, M1_N1); > } > > static void intel_ddi_pre_enable_hdmi(struct intel_encoder *encoder, diff --git > a/drivers/gpu/drm/i915/display/intel_display.c > b/drivers/gpu/drm/i915/display/intel_display.c > index 0b7112a29966..a5f6d501c133 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -6957,9 +6957,6 @@ static void hsw_crtc_enable(struct > intel_atomic_state *state, > > intel_encoders_pre_enable(state, crtc); > > - if (intel_crtc_has_dp_encoder(new_crtc_state)) > - intel_dp_set_m_n(new_crtc_state, M1_N1); > - > if (!transcoder_is_dsi(cpu_transcoder)) > intel_set_pipe_timings(new_crtc_state); > > -- > 2.20.1 > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
