On Wed, 29 Jan 2020, Vivek Kasireddy <vivek.kasireddy@xxxxxxxxx> wrote:
> Currently, the value assigned to the bool variable ddi_clk_needed
> is a pointer -- which appears to have happened inadvertently. Therefore,
> add a "!!" before the expression on the right to ensure that it results
> in a bool.
Please don't do this.
The !! is only needed for compressing the value to 0 or 1 when the left
operand is not a bool. It was customary in the days of yore when bool
was just a typedeffed int.
For standard bools, "When any scalar value is converted to _Bool, the
result is 0 if the value compares equal to 0; otherwise, the result is
1."
BR,
Jani.
>
> Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
> Signed-off-by: Vivek Kasireddy <vivek.kasireddy@xxxxxxxxx>
> ---
> drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
> index c96f629cddc3..6df485289bc6 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
> @@ -3109,7 +3109,7 @@ void icl_sanitize_encoder_pll_mapping(struct intel_encoder *encoder)
> }
>
> port_mask = BIT(encoder->port);
> - ddi_clk_needed = encoder->base.crtc;
> + ddi_clk_needed = !!encoder->base.crtc;
>
> if (encoder->type == INTEL_OUTPUT_DSI) {
> struct intel_encoder *other_encoder;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
