Re: [PATCH 3/5] drm/client: Rename _force to _locked

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 29, 2020 at 2:16 PM Noralf Trønnes <noralf@xxxxxxxxxxx> wrote:
> Den 29.01.2020 09.24, skrev Daniel Vetter:
> > Plus extend the kerneldoc a bit to explain how this should be used.
> > With the previous patch to drop the force restore the main user of
> > this function is not emphasis on the "I hold the internal master lock
>
> The _not_ confuses me, the emphasis is now that "I hold the lock" right?

Oops, I confused myself and mixed things up between old and new
meaning and what's now important and what not. s/not/now/, I'll fix
when applying.
-Daniel

>
> > already" aspect, so rename the function to match.
> >
> > Suggested by Noralf.
> >
> > Cc: Noralf Trønnes <noralf@xxxxxxxxxxx>
> > Signed-off-by: Daniel Vetter <daniel.vetter@xxxxxxxxx>
> > ---
>
> Reviewed-by: Noralf Trønnes <noralf@xxxxxxxxxxx>



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux