On Tue, 21 Jan 2020, Ville Syrjala <ville.syrjala@xxxxxxxxxxxxxxx> wrote: > From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> > > Add the missing comma after the last initialized element > of the hpd[] arrays. Best not give people bad ideas. > > Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx> > --- > drivers/gpu/drm/i915/i915_irq.c | 18 +++++++++--------- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c > index afc6aad9bf8c..8091d58f0392 100644 > --- a/drivers/gpu/drm/i915/i915_irq.c > +++ b/drivers/gpu/drm/i915/i915_irq.c > @@ -79,7 +79,7 @@ static const u32 hpd_ibx[HPD_NUM_PINS] = { > [HPD_SDVO_B] = SDE_SDVOB_HOTPLUG, > [HPD_PORT_B] = SDE_PORTB_HOTPLUG, > [HPD_PORT_C] = SDE_PORTC_HOTPLUG, > - [HPD_PORT_D] = SDE_PORTD_HOTPLUG > + [HPD_PORT_D] = SDE_PORTD_HOTPLUG, > }; > > static const u32 hpd_cpt[HPD_NUM_PINS] = { > @@ -87,7 +87,7 @@ static const u32 hpd_cpt[HPD_NUM_PINS] = { > [HPD_SDVO_B] = SDE_SDVOB_HOTPLUG_CPT, > [HPD_PORT_B] = SDE_PORTB_HOTPLUG_CPT, > [HPD_PORT_C] = SDE_PORTC_HOTPLUG_CPT, > - [HPD_PORT_D] = SDE_PORTD_HOTPLUG_CPT > + [HPD_PORT_D] = SDE_PORTD_HOTPLUG_CPT, > }; > > static const u32 hpd_spt[HPD_NUM_PINS] = { > @@ -95,7 +95,7 @@ static const u32 hpd_spt[HPD_NUM_PINS] = { > [HPD_PORT_B] = SDE_PORTB_HOTPLUG_CPT, > [HPD_PORT_C] = SDE_PORTC_HOTPLUG_CPT, > [HPD_PORT_D] = SDE_PORTD_HOTPLUG_CPT, > - [HPD_PORT_E] = SDE_PORTE_HOTPLUG_SPT > + [HPD_PORT_E] = SDE_PORTE_HOTPLUG_SPT, > }; > > static const u32 hpd_mask_i915[HPD_NUM_PINS] = { > @@ -104,7 +104,7 @@ static const u32 hpd_mask_i915[HPD_NUM_PINS] = { > [HPD_SDVO_C] = SDVOC_HOTPLUG_INT_EN, > [HPD_PORT_B] = PORTB_HOTPLUG_INT_EN, > [HPD_PORT_C] = PORTC_HOTPLUG_INT_EN, > - [HPD_PORT_D] = PORTD_HOTPLUG_INT_EN > + [HPD_PORT_D] = PORTD_HOTPLUG_INT_EN, > }; > > static const u32 hpd_status_g4x[HPD_NUM_PINS] = { > @@ -113,7 +113,7 @@ static const u32 hpd_status_g4x[HPD_NUM_PINS] = { > [HPD_SDVO_C] = SDVOC_HOTPLUG_INT_STATUS_G4X, > [HPD_PORT_B] = PORTB_HOTPLUG_INT_STATUS, > [HPD_PORT_C] = PORTC_HOTPLUG_INT_STATUS, > - [HPD_PORT_D] = PORTD_HOTPLUG_INT_STATUS > + [HPD_PORT_D] = PORTD_HOTPLUG_INT_STATUS, > }; > > static const u32 hpd_status_i915[HPD_NUM_PINS] = { > @@ -122,21 +122,21 @@ static const u32 hpd_status_i915[HPD_NUM_PINS] = { > [HPD_SDVO_C] = SDVOC_HOTPLUG_INT_STATUS_I915, > [HPD_PORT_B] = PORTB_HOTPLUG_INT_STATUS, > [HPD_PORT_C] = PORTC_HOTPLUG_INT_STATUS, > - [HPD_PORT_D] = PORTD_HOTPLUG_INT_STATUS > + [HPD_PORT_D] = PORTD_HOTPLUG_INT_STATUS, > }; > > /* BXT hpd list */ > static const u32 hpd_bxt[HPD_NUM_PINS] = { > [HPD_PORT_A] = BXT_DE_PORT_HP_DDIA, > [HPD_PORT_B] = BXT_DE_PORT_HP_DDIB, > - [HPD_PORT_C] = BXT_DE_PORT_HP_DDIC > + [HPD_PORT_C] = BXT_DE_PORT_HP_DDIC, > }; > > static const u32 hpd_gen11[HPD_NUM_PINS] = { > [HPD_PORT_C] = GEN11_TC1_HOTPLUG | GEN11_TBT1_HOTPLUG, > [HPD_PORT_D] = GEN11_TC2_HOTPLUG | GEN11_TBT2_HOTPLUG, > [HPD_PORT_E] = GEN11_TC3_HOTPLUG | GEN11_TBT3_HOTPLUG, > - [HPD_PORT_F] = GEN11_TC4_HOTPLUG | GEN11_TBT4_HOTPLUG > + [HPD_PORT_F] = GEN11_TC4_HOTPLUG | GEN11_TBT4_HOTPLUG, > }; > > static const u32 hpd_gen12[HPD_NUM_PINS] = { > @@ -145,7 +145,7 @@ static const u32 hpd_gen12[HPD_NUM_PINS] = { > [HPD_PORT_F] = GEN11_TC3_HOTPLUG | GEN11_TBT3_HOTPLUG, > [HPD_PORT_G] = GEN11_TC4_HOTPLUG | GEN11_TBT4_HOTPLUG, > [HPD_PORT_H] = GEN12_TC5_HOTPLUG | GEN12_TBT5_HOTPLUG, > - [HPD_PORT_I] = GEN12_TC6_HOTPLUG | GEN12_TBT6_HOTPLUG > + [HPD_PORT_I] = GEN12_TC6_HOTPLUG | GEN12_TBT6_HOTPLUG, > }; > > static const u32 hpd_icp[HPD_NUM_PINS] = { -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx