Quoting Mika Kuoppala (2020-01-27 09:54:25) > Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> writes: > > > If the HW min/max frequencies are the same, there is not much range to > > deal with and a couple of our invalid tests become confused as they are > > actually no-ops. > > > > Error reporting in i915_pm_rps is rudimentary and we deserve better. > > > > Closes: https://gitlab.freedesktop.org/drm/intel/issues/1008 > > Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx> > > --- > > tests/i915/i915_pm_rps.c | 16 ++++++++++------ > > 1 file changed, 10 insertions(+), 6 deletions(-) > > > > diff --git a/tests/i915/i915_pm_rps.c b/tests/i915/i915_pm_rps.c > > index b65eefb03..56c745a5b 100644 > > --- a/tests/i915/i915_pm_rps.c > > +++ b/tests/i915/i915_pm_rps.c > > @@ -397,9 +397,11 @@ static void min_max_config(void (*check)(void), bool load_gpu) > > writeval_inval(sysfs_files[MIN].filp, origfreqs[RP0] + 1000); > > check(); > > > > - igt_debug("\nDecrease max to RPn (invalid)...\n"); > > - writeval_inval(sysfs_files[MAX].filp, origfreqs[RPn]); > > - check(); > > + if (origfreqs[RPn] < origfreqs[RP0]) { > > + igt_debug("\nDecrease max to RPn (invalid)...\n"); > > + writeval_inval(sysfs_files[MAX].filp, origfreqs[RPn]); > > + check(); > > + } > > > > igt_debug("\nDecrease min to midpoint...\n"); > > writeval(sysfs_files[MIN].filp, fmid); > > @@ -429,9 +431,11 @@ static void min_max_config(void (*check)(void), bool load_gpu) > > writeval_inval(sysfs_files[MAX].filp, 0); > > check(); > > > > - igt_debug("\nIncrease min to RP0 (invalid)...\n"); > > - writeval_inval(sysfs_files[MIN].filp, origfreqs[RP0]); > > - check(); > > + if (origfreqs[RP0] > origfreqs[RP0]) { > > RPn? if (RP0 > RPn) -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
