On Mon, Jan 20, 2020 at 07:47:22PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
>
> Move intel_atomic_state_free() next to its counterpart.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx>
Reviewed-by: Imre Deak <imre.deak@xxxxxxxxx>
Some exported functions in this file are missing documentation.
> ---
> drivers/gpu/drm/i915/display/intel_atomic.c | 11 +++++++++++
> drivers/gpu/drm/i915/display/intel_atomic.h | 1 +
> drivers/gpu/drm/i915/display/intel_display.c | 11 -----------
> 3 files changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_atomic.c b/drivers/gpu/drm/i915/display/intel_atomic.c
> index 1269f63ea006..1c13423d4945 100644
> --- a/drivers/gpu/drm/i915/display/intel_atomic.c
> +++ b/drivers/gpu/drm/i915/display/intel_atomic.c
> @@ -495,6 +495,17 @@ intel_atomic_state_alloc(struct drm_device *dev)
> return &state->base;
> }
>
> +void intel_atomic_state_free(struct drm_atomic_state *_state)
> +{
> + struct intel_atomic_state *state = to_intel_atomic_state(_state);
> +
> + drm_atomic_state_default_release(&state->base);
> +
> + i915_sw_fence_fini(&state->commit_ready);
> +
> + kfree(state);
> +}
> +
> void intel_atomic_state_clear(struct drm_atomic_state *s)
> {
> struct intel_atomic_state *state = to_intel_atomic_state(s);
> diff --git a/drivers/gpu/drm/i915/display/intel_atomic.h b/drivers/gpu/drm/i915/display/intel_atomic.h
> index 74c749dbfb4f..88133eea0a17 100644
> --- a/drivers/gpu/drm/i915/display/intel_atomic.h
> +++ b/drivers/gpu/drm/i915/display/intel_atomic.h
> @@ -45,6 +45,7 @@ void intel_crtc_destroy_state(struct drm_crtc *crtc,
> void intel_crtc_free_hw_state(struct intel_crtc_state *crtc_state);
> void intel_crtc_copy_color_blobs(struct intel_crtc_state *crtc_state);
> struct drm_atomic_state *intel_atomic_state_alloc(struct drm_device *dev);
> +void intel_atomic_state_free(struct drm_atomic_state *state);
> void intel_atomic_state_clear(struct drm_atomic_state *state);
>
> struct intel_crtc_state *
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 63efb8f9c669..3b725764bdcd 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -17116,17 +17116,6 @@ intel_user_framebuffer_create(struct drm_device *dev,
> return fb;
> }
>
> -static void intel_atomic_state_free(struct drm_atomic_state *state)
> -{
> - struct intel_atomic_state *intel_state = to_intel_atomic_state(state);
> -
> - drm_atomic_state_default_release(state);
> -
> - i915_sw_fence_fini(&intel_state->commit_ready);
> -
> - kfree(state);
> -}
> -
> static enum drm_mode_status
> intel_mode_valid(struct drm_device *dev,
> const struct drm_display_mode *mode)
> --
> 2.24.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
