== Series Details == Series: drm/i915/gem: Implement parallel execbuffer submission. URL : https://patchwork.freedesktop.org/series/72521/ State : warning == Summary == $ dim checkpatch origin/drm-tip ac32dc249279 drm/i915: Drop inspection of execbuf flags during evict dbffec8e6129 drm/i915/gem: Extract transient execbuf flags from i915_vma b3ff4cd5c2b0 drm/i915: Separate lookup and pinning in execbuf. -:153: CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #153: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:858: + } total: 0 errors, 0 warnings, 1 checks, 190 lines checked 8745975ba8ef drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2. -:528: WARNING:LONG_LINE: line over 100 characters #528: FILE: drivers/gpu/drm/i915/i915_gem.c:1337: + while ((obj = list_first_entry_or_null(&ww->obj_list, struct drm_i915_gem_object, obj_link))) { total: 0 errors, 1 warnings, 0 checks, 497 lines checked e0cd1376e2da drm/i915: Remove locking from i915_gem_object_prepare_read/write ceeddaf549ea drm/i915: Parse command buffer earlier in eb_relocate(slow) 7a269ec65bee drm/i915: Use per object locking in execbuf on top of struct_mutex, v2. -:212: CHECK:BRACES: braces {} should be used on all arms of this statement #212: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1834: + if (err == -EDEADLK) { [...] + else if (err) [...] -:220: ERROR:ELSE_AFTER_BRACE: else should follow close brace '}' #220: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:1842: + } + else if (err) total: 1 errors, 0 warnings, 1 checks, 315 lines checked c4a3a05075bb drm/i915: Use ww locking in intel_renderstate. -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #10: Convert to using ww-waiting, and make sure we always pin intel_context_state, total: 0 errors, 1 warnings, 0 checks, 202 lines checked 137db377e250 drm/i915: Add ww context handling to context_barrier_task -:19: WARNING:LONG_LINE: line over 100 characters #19: FILE: drivers/gpu/drm/i915/gem/i915_gem_context.c:931: + int (*pin)(struct intel_context *ce, struct i915_gem_ww_ctx *ww, void *data), total: 0 errors, 1 warnings, 0 checks, 146 lines checked 02495dc4b9f9 drm/i915: Nuke arguments to eb_pin_engine af62c8b5c8b4 drm/i915: Pin engine before pinning all objects cae78048f977 drm/i915: Rework intel_context pinning to do everything outside of pin_mutex -:314: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #314: FILE: drivers/gpu/drm/i915/gt/intel_lrc.c:2894: + *vaddr = i915_gem_object_pin_map(ce->state->obj, + i915_coherent_map_type(ce->engine->i915) | total: 0 errors, 0 warnings, 1 checks, 420 lines checked 1744b1a75cc8 drm/i915: Make sure execbuffer always passes ww state to i915_vma_pin. -:64: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #64: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:582: + err = i915_vma_pin_ww(vma, &eb->ww, entry->pad_to_size, entry->alignment, total: 0 errors, 0 warnings, 1 checks, 532 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx