On 22/01/2020 14:46, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2020-01-22 14:40:28)static void init_engine(struct intel_execution_engine2 *e2, int class, int instance, uint64_t flags) { - const struct intel_execution_engine2 *__e2; - static const char *unknown_name = "unknown", - *virtual_name = "virtual"; + int ret;e2->class = class;e2->instance = instance; - e2->flags = flags;/* engine is a virtual engine */if (class == I915_ENGINE_CLASS_INVALID && instance == I915_ENGINE_CLASS_INVALID_VIRTUAL) {Can this ever match? instance is 65534 and INVALID_VIRTUAL is -2. int class/instance should be u16?
Yeah, no it can't ever match. I'll have a look how easy to change it all to struct i915_engine_class_instance.
Regards, Tvrtko _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
