Hi Am 21.01.20 um 10:25 schrieb Jani Nikula: > > Thomas, please fix the sparse/build warnings. > > BR, > Jani. > > > On Mon, 20 Jan 2020, Patchwork <patchwork@xxxxxxxxxxxxxxxxxxxxxx> wrote: >> == Series Details == >> >> Series: drm: Clean up VBLANK callbacks in struct drm_driver (rev8) >> URL : https://patchwork.freedesktop.org/series/71873/ >> State : warning >> >> == Summary == >> >> $ dim sparse origin/drm-tip >> Sparse version: v0.6.0 >> Commit: drm: Remove internal setup of struct drm_device.vblank_disable_immediate >> Okay! >> >> Commit: drm: Add get_scanout_position() to struct drm_crtc_helper_funcs >> Okay! >> >> Commit: drm: Add get_vblank_timestamp() to struct drm_crtc_funcs >> + ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> +drivers/gpu/drm/drm_vblank.c:1869:19: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses] >> +drivers/gpu/drm/drm_vblank.c: In function ‘drm_handle_vblank_events’: >> + high_prec = crtc && crtc->funcs->get_vblank_timestamp || Yeah, Ville also mentioned this. I'll change this code to something more readable. >> >> Commit: drm/amdgpu: Convert to struct drm_crtc_helper_funcs.get_scanout_position() >> -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5057:6: warning: symbol 'dm_drm_plane_destroy_state' was not declared. Should it be static? >> +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5058:6: warning: symbol 'dm_drm_plane_destroy_state' was not declared. Should it be static? >> -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8393:6: warning: symbol 'amdgpu_dm_psr_enable' was not declared. Should it be static? >> -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8397:50: warning: missing braces around initializer >> +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8394:6: warning: symbol 'amdgpu_dm_psr_enable' was not declared. Should it be static? >> +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8398:50: warning: missing braces around initializer >> >> Commit: drm/amdgpu: Convert to CRTC VBLANK callbacks >> -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5058:6: warning: symbol 'dm_drm_plane_destroy_state' was not declared. Should it be static? >> +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:5060:6: warning: symbol 'dm_drm_plane_destroy_state' was not declared. Should it be static? >> -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8394:6: warning: symbol 'amdgpu_dm_psr_enable' was not declared. Should it be static? >> -drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8398:50: warning: missing braces around initializer >> +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8396:6: warning: symbol 'amdgpu_dm_psr_enable' was not declared. Should it be static? >> +drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:8400:50: warning: missing braces around initializer Those are not my warnings, but I'll see if there's a simple fix that I can submit. Best regards Thomas >> >> Commit: drm/gma500: Convert to CRTC VBLANK callbacks >> Okay! >> >> Commit: drm/i915: Convert to CRTC VBLANK callbacks >> Okay! >> >> Commit: drm/nouveau: Convert to struct drm_crtc_helper_funcs.get_scanout_position() >> Okay! >> >> Commit: drm/nouveau: Convert to CRTC VBLANK callbacks >> Okay! >> >> Commit: drm/radeon: Convert to struct drm_crtc_helper_funcs.get_scanout_position() >> Okay! >> >> Commit: drm/radeon: Convert to CRTC VBLANK callbacks >> Okay! >> >> Commit: drm/msm: Convert to struct drm_crtc_helper_funcs.get_scanout_position() >> Okay! >> >> Commit: drm/msm: Convert to CRTC VBLANK callbacks >> Okay! >> >> Commit: drm/stm: Convert to struct drm_crtc_helper_funcs.get_scanout_position() >> Okay! >> >> Commit: drm/stm: Convert to CRTC VBLANK callbacks >> Okay! >> >> Commit: drm/sti: Convert to CRTC VBLANK callbacks >> Okay! >> >> Commit: drm/vc4: Convert to struct drm_crtc_helper_funcs.get_scanout_position() >> Okay! >> >> Commit: drm/vc4: Convert to CRTC VBLANK callbacks >> Okay! >> >> Commit: drm/vkms: Convert to CRTC VBLANK callbacks >> Okay! >> >> Commit: drm/vmwgfx: Convert to CRTC VBLANK callbacks >> Okay! >> >> Commit: drm: Clean-up VBLANK-related callbacks in struct drm_driver >> - ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >> -drivers/gpu/drm/drm_vblank.c: In function ‘drm_handle_vblank_events’: >> - high_prec = crtc && crtc->funcs->get_vblank_timestamp || >> -O:drivers/gpu/drm/drm_vblank.c:1869:19: warning: suggest parentheses around ‘&&’ within ‘||’ [-Wparentheses] >> >> Commit: drm: Remove legacy version of get_scanout_position() >> Okay! >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@xxxxxxxxxxxxxxxxxxxxx >> https://lists.freedesktop.org/mailman/listinfo/intel-gfx > -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Maxfeldstr. 5, 90409 Nürnberg, Germany (HRB 36809, AG Nürnberg) Geschäftsführer: Felix Imendörffer
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
