Quoting Akeem G Abodunrin (2020-01-16 17:46:55) > +static u32 > +gen7_fill_interface_descriptor(struct batch_chunk *state, > + const struct batch_vals *bv, > + const struct cb_kernel *kernel, > + unsigned int count) > +{ > + u32 *cs = batch_alloc_items(state, 32, 8 * count); > + u32 offset = batch_offset(state, cs); > + > + *cs++ = gen7_fill_kernel_data(state, kernel->data, kernel->size); > + *cs++ = (1 << 7) | (1 << 13); > + *cs++ = 0; > + *cs++ = (gen7_fill_binding_table(state, bv) - state->offset) | 1; > + *cs++ = 0; > + *cs++ = 0; > + *cs++ = 0; > + *cs++ = 0; > + /* 1 - 63dummy idds */ > + memset32(cs, 0x00, (count - 1) * 8); > + batch_advance(state, cs); cs is not at the end of the pack here. [cs + (count - 1) * 8] > + > + return offset; > +} All others look ok. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx