On Fri, 17 Jan 2020, Andi Shyti <andi.shyti@xxxxxxxxx> wrote:
> Hi Zhang,
>
> On Fri, Jan 17, 2020 at 03:34:36PM +0800, Zhang Xiaoxu wrote:
>> Since commit 742379c0c4001 ("drm/i915: Start chopping up the GPU error
>> capture"), function 'i915_error_state_store' was defined and used with
>> only one parameter.
>>
>> But if no 'CONFIG_DRM_I915_CAPTURE_ERROR', this function was defined
>> with two parameter.
>>
>> This may lead compile error. This patch fix it.
>>
>> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
>
> I've never been a fan of non human accounts, we had this discussion
> already in a different mailing list. Could you please find a
> different way of giving credit to your CI system?
I don't actually mind for Reported-by credits. The history is full of
things like:
Reported-by: kbuild test robot <lkp@xxxxxxxxx>
Reported-by: syzbot+ec24e95ea483de0a24da@xxxxxxxxxxxxxxxxxxxxxxxxx
Care to reference the discussion?
BR,
Janid.
>
>> Signed-off-by: Zhang Xiaoxu <zhangxiaoxu5@xxxxxxxxxx>
>> ---
>> drivers/gpu/drm/i915/i915_gpu_error.h | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.h b/drivers/gpu/drm/i915/i915_gpu_error.h
>> index 9109004956bd..41c1475e1500 100644
>> --- a/drivers/gpu/drm/i915/i915_gpu_error.h
>> +++ b/drivers/gpu/drm/i915/i915_gpu_error.h
>> @@ -314,8 +314,7 @@ i915_vma_capture_finish(struct intel_gt_coredump *gt,
>> }
>>
>> static inline void
>> -i915_error_state_store(struct drm_i915_private *i915,
>> - struct i915_gpu_coredump *error)
>> +i915_error_state_store(struct i915_gpu_coredump *error)
>
> ouch! that's an oversight.
>
> Thanks for your patch,
>
> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxx>
>
> Andi
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
