== Series Details == Series: drm: Introduce struct drm_device based WARN* and use them in i915 (rev2) URL : https://patchwork.freedesktop.org/series/72035/ State : warning == Summary == $ dim checkpatch origin/drm-tip 18f3673543e1 drm/print: introduce new struct drm_device based WARN* macros -:37: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'drm' - possible side-effects? #37: FILE: include/drm/drm_print.h:567: +#define drm_WARN(drm, condition, format, arg...) \ + WARN(condition, "%s %s: " format, \ + dev_driver_string((drm)->dev), \ + dev_name((drm)->dev), ## arg) -:42: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'drm' - possible side-effects? #42: FILE: include/drm/drm_print.h:572: +#define drm_WARN_ONCE(drm, condition, format, arg...) \ + WARN_ONCE(condition, "%s %s: " format, \ + dev_driver_string((drm)->dev), \ + dev_name((drm)->dev), ## arg) -:47: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #47: FILE: include/drm/drm_print.h:577: +#define drm_WARN_ON(drm, x) \ + drm_WARN((drm), (x), "%s", \ + "drm_WARN_ON(" __stringify(x) ")") -:51: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #51: FILE: include/drm/drm_print.h:581: +#define drm_WARN_ON_ONCE(drm, x) \ + drm_WARN_ONCE((drm), (x), "%s", \ + "drm_WARN_ON_ONCE(" __stringify(x) ")") total: 0 errors, 0 warnings, 4 checks, 33 lines checked 92983812e74b drm/i915/display: Make WARN* drm specific where drm_device ptr is available e49c4974bb9e drm/i915/display: Make WARN* drm specific where drm_priv ptr is available -:1248: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1248: FILE: drivers/gpu/drm/i915/display/intel_display.c:15228: + skl_ddb_allocation_overlaps( -:1261: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1261: FILE: drivers/gpu/drm/i915/display/intel_display.c:15265: + skl_ddb_allocation_overlaps( -:1992: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #1992: FILE: drivers/gpu/drm/i915/display/intel_dp.c:5673: + !drm_modeset_is_locked( -:2060: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2060: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:107: + if (drm_WARN_ON(&dev_priv->drm, pll < dev_priv->shared_dplls || + pll > &dev_priv->shared_dplls[dev_priv->num_shared_dpll])) -:2079: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!pll" #2079: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:144: + if (drm_WARN_ON(&dev_priv->drm, pll == NULL)) -:2097: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!pll" #2097: FILE: drivers/gpu/drm/i915/display/intel_dpll_mgr.c:173: + if (drm_WARN_ON(&dev_priv->drm, pll == NULL)) -:2602: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #2602: FILE: drivers/gpu/drm/i915/display/intel_overlay.c:763: + !drm_modeset_is_locked( -:2613: CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #2613: FILE: drivers/gpu/drm/i915/display/intel_overlay.c:863: + !drm_modeset_is_locked( -:2919: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #2919: FILE: drivers/gpu/drm/i915/display/intel_tc.c:415: + intel_display_power_is_enabled(i915, + intel_aux_power_domain(dig_port))); total: 0 errors, 0 warnings, 9 checks, 2504 lines checked f1c69c04fbdd drm/i915/display: Make WARN* drm specific where encoder ptr is available 6328a5e08b71 drm/i915/gem: Make WARN* drm specific where drm_priv ptr is available -:84: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #84: FILE: drivers/gpu/drm/i915/gem/i915_gem_pm.c:89: + drm_WARN_ON(&i915->drm, + i915_gem_object_set_to_gtt_domain(obj, false)); total: 0 errors, 0 warnings, 1 checks, 77 lines checked 4e722d898e37 drm/i915/gt: Make WARN* drm specific where drm_priv ptr is available d8994a89f0e2 drm/i915/gvt: Make WARN* drm specific where drm_priv ptr is available 61233e2191ac drm/i915/gvt: Make WARN* drm specific where vgpu ptr is available -:296: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #296: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1373: + drm_WARN_ONCE(&i915->drm, 1, + "VM(%d): iGVT-g doesn't support GuC\n", -:310: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #310: FILE: drivers/gpu/drm/i915/gvt/handlers.c:1389: + drm_WARN(&i915->drm, 1, + "VM(%d): Use physical address for TRTT!\n", -:397: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis #397: FILE: drivers/gpu/drm/i915/gvt/interrupt.c:347: + drm_WARN_ON(&i915->drm, + up_irq_info != irq->info[map->up_irq_group]); total: 0 errors, 0 warnings, 3 checks, 519 lines checked f3d36b64b57e drm/i915: Make WARN* drm specific where drm_priv ptr is available ab58d9547a99 drm/i915: Make WARN* drm specific where uncore or stream ptr is available _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
