== Series Details == Series: Commit early to GuC URL : https://patchwork.freedesktop.org/series/72031/ State : warning == Summary == $ dim checkpatch origin/drm-tip c114a4a8e211 drm/i915/guc: Kill USES_GUC macro 033b28e648f2 drm/i915/guc: Kill USES_GUC_SUBMISSION macro 4eb628448c92 drm/i915/uc: Improve tracking of uC init status -:208: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #208: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:64: +#define __uc_state_checker(x, state, required) \ +static inline bool intel_uc_##state##_##x(struct intel_uc *uc) \ +{ \ + return intel_##x##_is_##required(&uc->x); \ } -:214: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #214: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:70: +#define uc_state_checkers(x) \ +__uc_state_checker(x, supports, supported) \ +__uc_state_checker(x, wants, wanted) \ +__uc_state_checker(x, uses, used) -:214: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #214: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:70: +#define uc_state_checkers(x) \ +__uc_state_checker(x, supports, supported) \ +__uc_state_checker(x, wants, wanted) \ +__uc_state_checker(x, uses, used) total: 1 errors, 0 warnings, 2 checks, 190 lines checked 827bb05aa73b drm/i915/uc: Abort early on uc_init failure e46e55860fda drm/i915/guc: Apply new uC status tracking to GuC submission as well -:211: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues #211: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:64: +#define __uc_state_checker(x, func, state, required) \ +static inline bool intel_uc_##state##_##func(struct intel_uc *uc) \ { \ + return intel_##func##_is_##required(&uc->x); \ } -:222: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #222: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:70: +#define uc_state_checkers(x, func) \ +__uc_state_checker(x, func, supports, supported) \ +__uc_state_checker(x, func, wants, wanted) \ +__uc_state_checker(x, func, uses, used) -:222: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'x' - possible side-effects? #222: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:70: +#define uc_state_checkers(x, func) \ +__uc_state_checker(x, func, supports, supported) \ +__uc_state_checker(x, func, wants, wanted) \ +__uc_state_checker(x, func, uses, used) -:222: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'func' - possible side-effects? #222: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:70: +#define uc_state_checkers(x, func) \ +__uc_state_checker(x, func, supports, supported) \ +__uc_state_checker(x, func, wants, wanted) \ +__uc_state_checker(x, func, uses, used) total: 1 errors, 0 warnings, 3 checks, 225 lines checked 6e76e718c238 drm/i915/guc: Start considering GuC submission a proper back-end 522c1abc9b0b HAX: force enable_guc=2 -:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one total: 0 errors, 1 warnings, 0 checks, 8 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
