== Series Details == Series: Add ops to intel_uc (rev4) URL : https://patchwork.freedesktop.org/series/70716/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2e1f188d8ce3 drm/i915/uc: Add ops to intel_uc -:147: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #147: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:73: +#define intel_uc_ops_function(_NAME, _OPS, _TYPE, _RET) \ +static inline _TYPE intel_uc_##_NAME(struct intel_uc *uc) \ +{ \ + if (uc->ops->_OPS) \ + return uc->ops->_OPS(uc); \ + return _RET; \ +} -:147: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_OPS' - possible side-effects? #147: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:73: +#define intel_uc_ops_function(_NAME, _OPS, _TYPE, _RET) \ +static inline _TYPE intel_uc_##_NAME(struct intel_uc *uc) \ +{ \ + if (uc->ops->_OPS) \ + return uc->ops->_OPS(uc); \ + return _RET; \ +} -:147: CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_OPS' may be better as '(_OPS)' to avoid precedence issues #147: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:73: +#define intel_uc_ops_function(_NAME, _OPS, _TYPE, _RET) \ +static inline _TYPE intel_uc_##_NAME(struct intel_uc *uc) \ +{ \ + if (uc->ops->_OPS) \ + return uc->ops->_OPS(uc); \ + return _RET; \ +} -:154: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #154: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:80: +} +intel_uc_ops_function(init_hw, init_hw, int, 0); -:155: ERROR:SPACING: space prohibited before that close parenthesis ')' #155: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:81: +intel_uc_ops_function(fini_hw, fini_hw, void, ); total: 2 errors, 0 warnings, 3 checks, 119 lines checked f899ba846e7d drm/i915/uc: Add init_fw/fini_fw to to intel_uc_ops -:79: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #79: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:80: } +intel_uc_ops_function(fetch_firmwares, init_fw, void, ); -:79: ERROR:SPACING: space prohibited before that close parenthesis ')' #79: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:80: +intel_uc_ops_function(fetch_firmwares, init_fw, void, ); -:80: ERROR:SPACING: space prohibited before that close parenthesis ')' #80: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:81: +intel_uc_ops_function(cleanup_firmwares, fini_fw, void, ); total: 2 errors, 0 warnings, 1 checks, 55 lines checked cb2532cf174b drm/i915/uc: Add init/fini to to intel_uc_ops -:81: ERROR:SPACING: space prohibited before that close parenthesis ')' #81: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:82: +intel_uc_ops_function(init, init, void, ); -:82: ERROR:SPACING: space prohibited before that close parenthesis ')' #82: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:83: +intel_uc_ops_function(fini, fini, void, ); total: 2 errors, 0 warnings, 0 checks, 57 lines checked ab06f9906171 drm/i915/uc: Add sanitize to to intel_uc_ops -:67: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations #67: FILE: drivers/gpu/drm/i915/gt/uc/intel_uc.h:80: } +intel_uc_ops_function(sanitize, sanitize, int, 0); total: 0 errors, 0 warnings, 1 checks, 43 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
