On Fri, Oct 26, 2012 at 09:21:05AM +0300, Jani Nikula wrote: > On Tue, 23 Oct 2012, Chris Wilson <chris at chris-wilson.co.uk> wrote: > > On Mon, 22 Oct 2012 16:12:18 +0300, Jani Nikula <jani.nikula at intel.com> wrote: > >> SDVOB may be multiplexed with HDMIB. If it's not SDVOB, the same i2c > >> adapter may be used for HDMIB, with the adjusted config (i.e. with GPIO > >> bit-banging instead of gmbus). Restore i2c adapter config before error > >> return from intel_sdvo_init(), letting HDMIB enjoy the joys of gmbus. > > > > I would personally not make the assumption that set_speed has no effect. > > Disabling GMBUS is a hack that we should eventually lift. > > I guess this comment was more about the whole, not just patch 2/2, but > Daniel merged 1/2 already. IIUC you would have wanted to keep set_speed > there, but shall we just leave that to when we start using GMBUS on > SDVO? Patch 2/2 is pretty straightforward, but will also need some love > when enabling GMBUS. Actually I wanted to merge both patches already. I've reordered things a bit and added a comment to explain why we'd like to use gmbus for sdvo (2MHz clock is simply faster), but that we have bugs with gmbus and so must fall back to bit banging. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch
