On 27-Dec-19 2:39 AM, Lucas De Marchi wrote:
On Wed, Dec 25, 2019 at 10:07 AM Swati Sharma <swati2.sharma@xxxxxxxxx> wrote:Increase the log level if DSB engine gets busy. If dsb engine is busy, it should be an error condition to indicate there might be some difficulty with the hardware. If DSB engine gets busy, load luts will fail and as per current driver design if one instance of DSB engine gets busy, we are not allocating the other instance. So, increase the log level to indicate there could be an issue with driver/hardware. Signed-off-by: Swati Sharma <swati2.sharma@xxxxxxxxx> --- drivers/gpu/drm/i915/display/intel_dsb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c index ada006a690df..6f67b5dfa128 100644 --- a/drivers/gpu/drm/i915/display/intel_dsb.c +++ b/drivers/gpu/drm/i915/display/intel_dsb.c @@ -52,7 +52,7 @@ static inline bool intel_dsb_enable_engine(struct intel_dsb *dsb) dsb_ctrl = I915_READ(DSB_CTRL(pipe, dsb->id)); if (DSB_STATUS & dsb_ctrl) { - DRM_DEBUG_KMS("DSB engine is busy.\n"); + DRM_ERROR("DSB engine is busy.\n");are we seeing this? Isn't it a dbg message because in this case we would fallback to direct mmio?
We are seeing this issue and is already under debug. https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7630/shard-tglb5/igt@kms_available_modes_crc@available_mode_test_crc.html <7> [303.727858] [drm:intel_dsb_commit [i915]] DSB engine is busy. <7> [303.727975] [drm:icl_load_luts [i915]] DSB engine is busy.
Lucas De Marchireturn false; } @@ -72,7 +72,7 @@ static inline bool intel_dsb_disable_engine(struct intel_dsb *dsb) dsb_ctrl = I915_READ(DSB_CTRL(pipe, dsb->id)); if (DSB_STATUS & dsb_ctrl) { - DRM_DEBUG_KMS("DSB engine is busy.\n"); + DRM_ERROR("DSB engine is busy.\n"); return false; } -- 2.24.1 _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
-- ~Swati Sharma _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
