✗ Fi.CI.CHECKPATCH: warning for Per client engine busyness (rev2)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



== Series Details ==

Series: Per client engine busyness (rev2)
URL   : https://patchwork.freedesktop.org/series/70977/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
c0a00684578c drm/i915: Switch context id allocation directoy to xarray
884f76e9c8c3 drm/i915: Reference count struct drm_i915_file_private
-:6: WARNING:TYPO_SPELLING: 'develope' may be misspelled - perhaps 'develop'?
#6: 
In the following patches we will develope a need to peek into the client

total: 0 errors, 1 warnings, 0 checks, 70 lines checked
8b12b7cce4b8 drm/i915: Expose list of clients in sysfs
a81f7132f3ac drm/i915: Update client name on context create
de1d52278f7f drm/i915: Track per-context engine busyness
86c433d16fd4 drm/i915: Track all user contexts per client
-:92: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#92: FILE: drivers/gpu/drm/i915/i915_drv.h:237:
+		spinlock_t ctx_lock;

total: 0 errors, 0 warnings, 1 checks, 114 lines checked
c17f2c454f61 drm/i915: Contexts can use struct pid stored in the client
c6adb62d2587 drm/i915: Expose per-engine client busyness
-:25: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#25: 
     Render/3D/0   63.73% |███████████████████           |      3%      0%

-:119: WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#119: FILE: drivers/gpu/drm/i915/i915_gem.c:1582:
+static const char *uabi_class_names[] = {

-:144: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#144: FILE: drivers/gpu/drm/i915/i915_gem.c:1633:
+       if (i915->caps.scheduler & I915_SCHEDULER_CAP_ENGINE_BUSY_STATS) {$

-:144: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (7, 16)
#144: FILE: drivers/gpu/drm/i915/i915_gem.c:1633:
+       if (i915->caps.scheduler & I915_SCHEDULER_CAP_ENGINE_BUSY_STATS) {
+		client->busy_root =

total: 0 errors, 4 warnings, 0 checks, 145 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux