Quoting Chris Wilson (2019-12-16 18:17:16)
> If we inherit an error along the fence chain, we skip the main work
> callback and go straight to the error. In the case of the vma bind
> worker, we only dropped the pinned pages from the worker.
>
> In the process, make sure we call the release earlier rather than wait
> until the final reference to the fence is dropped (as a reference is
> kept while being listened upon).
>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
<SNIP>
> +++ b/drivers/gpu/drm/i915/i915_vma.c
> @@ -292,6 +292,7 @@ i915_vma_instance(struct drm_i915_gem_object *obj,
> struct i915_vma_work {
> struct dma_fence_work base;
> struct i915_vma *vma;
> + struct drm_i915_gem_object *pin;
This would reach much nicer as "pinned" to me.
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
