Re: [igt-dev] [PATCH i-g-t] i915/perf: Skip OA testing on systems too old

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 16/12/2019 11:34, Chris Wilson wrote:
Don't flat out fail if the system doesn't support OA, just skip.

Closes: https://gitlab.freedesktop.org/drm/intel/issues/834
Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
---
  tests/perf.c | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/tests/perf.c b/tests/perf.c
index f5dd6051e..12f552743 100644
--- a/tests/perf.c
+++ b/tests/perf.c
@@ -884,11 +884,9 @@ init_sys_info(void)
  	const char *test_set_uuid = NULL;
  	char buf[256];
- igt_assert_neq(devid, 0);
-
  	timestamp_frequency = get_cs_timestamp_frequency();
  	igt_debug("timestamp_frequency = %lu\n", timestamp_frequency);
-	igt_assert_neq(timestamp_frequency, 0);
+	igt_require(timestamp_frequency);
if (IS_HASWELL(devid)) {
  		/* We don't have a TestOa metric set for Haswell so use

I guess I'm too young to know that some platforms don't even have a timestamp register...

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx>


Thanks,


-Lionel

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux