Re: [PATCH v5 2/2] drm/i915/gt: Move power management debug files into a gt aware debugfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Andi Shyti (2019-12-13 21:17:36)
> > > The GT system is becoming more and more a stand-alone system in
> > > i915 and it's fair to assign it its own debugfs directory.
> > > 
> > > rc6, rps and llc debugfs files are gt related, move them into the
> > > gt debugfs directory.
> > > 
> > > Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxx>
> > > ---
> > >  drivers/gpu/drm/i915/Makefile              |   2 +
> > >  drivers/gpu/drm/i915/gt/intel_debugfs_gt.c |  23 +
> > >  drivers/gpu/drm/i915/gt/intel_debugfs_gt.h |  27 +
> > >  drivers/gpu/drm/i915/gt/intel_debugfs_pm.c | 623 +++++++++++++++++++++
> > >  drivers/gpu/drm/i915/gt/intel_debugfs_pm.h |  16 +
> > 
> > That's the worst of all worlds. debugfs is not a piece of intel hw.
> 
> I don't see other way for having everything grouped by name. We
> can keep the previous patch (v4) with "debugfs_*", then.
> 
> Is that fine? If so we can just ignore this version.

I had no objections, just a suggestion for gt-${CONFIG_DEBUGFS} :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux