Re: [PATCH 2/2] drm/i915: Make warned variable private

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Lucas De Marchi (2019-12-11 22:20:13)
> On Wed, Dec 11, 2019 at 04:19:58PM +0000, Chris Wilson wrote:
> >Quoting Chris Wilson (2019-12-11 16:17:23)
> >> Quoting Venkata Sandeep Dhanalakota (2019-12-11 16:07:24)
> >> > Make each instance to report the hang only once.
> >> >
> >> > Cc: Sudeep Dutt <sudeep.dutt@xxxxxxxxx>
> >> > Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
> >> > Cc: Daniel Vetter <daniel.vetter@xxxxxxxx>
> >> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> >> > Cc: Jani Nikula <jani.nikula@xxxxxxxxx>
> >> > Signed-off-by: Venkata Sandeep Dhanalakota <venkata.s.dhanalakota@xxxxxxxxx>
> >>
> >> I still don't think so, since the we only want to pester the _user_ once
> >> to file a bug, and that is irrespective of the device.
> >
> >Or to put it another way, the dmesg stream is global and this is a flag
> >around that stream.
> 
> maybe we could use WARN_ONCE()?

It's not a warning and doesn't justify being one.
-Chris
---------------------------------------------------------------------
Intel Corporation (UK) Limited
Registered No. 1134945 (England)
Registered Office: Pipers Way, Swindon SN3 1RJ
VAT No: 860 2173 47

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx



[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux