Quoting Chris Wilson (2019-12-07 19:01:06)
> As the caller no longer uses the i915_vma result, stop returning it and
> just return the error code instead.
>
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
<SNIP>
> @@ -2002,8 +2007,6 @@ static struct i915_vma *eb_parse(struct i915_execbuffer *eb)
> eb->batch_len,
> vma);
> if (err) {
> - i915_vma_unpin(vma);
> -
> /*
> * Unsafe GGTT-backed buffers can still be submitted safely
> * as non-secure.
> @@ -2012,10 +2015,8 @@ static struct i915_vma *eb_parse(struct i915_execbuffer *eb)
> */
> if (i915_vma_is_ggtt(vma) && err == -EACCES)
> /* Execute original buffer non-secure */
This second comment is bit of a repetition, especially after the code
flow is simplified.
Either way;
Reviewed-by: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Regards, Joonas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
