Quoting Michal Wajdeczko (2019-12-10 21:02:30) > On Tue, 10 Dec 2019 21:55:13 +0100, Chris Wilson > <chris@xxxxxxxxxxxxxxxxxx> wrote: > > > Quoting Michal Wajdeczko (2019-12-10 20:47:41) > >> @@ -628,3 +651,15 @@ int intel_uc_runtime_resume(struct intel_uc *uc) > >> */ > >> return __uc_resume(uc, true); > >> } > >> + > >> +const struct intel_uc_ops uc_ops_none = { > >> +}; > >> + > >> +const struct intel_uc_ops uc_ops_off = { > >> + .init_hw = __uc_check_hw, > >> +}; > >> + > >> +const struct intel_uc_ops uc_ops_on = { > >> + .init_hw = __uc_init_hw, > >> + .fini_hw = __uc_fini_hw, > >> +}; > > > > No externs in the headers, so should these be static? > > but then forwards from top of the file will not work. > and early_init will have to be moved here as well. > doable, but wanted to minimize diffs during rfc phase. static forward decls. -Chris _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx