On Tue, 03 Dec 2019, Jani Nikula <jani.nikula@xxxxxxxxx> wrote: > Now that the fbops member of struct fb_info is const, we can start > making the ops const as well. > > v2: fix typo (Christophe de Dinechin) > > Cc: Bruno Prémont <bonbons@xxxxxxxxxxxxxxxxx> > Cc: linux-input@xxxxxxxxxxxxxxx > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > Acked-by: Bruno Prémont <bonbons@xxxxxxxxxxxxxxxxx> > Signed-off-by: Jani Nikula <jani.nikula@xxxxxxxxx> Pushed to drm-misc-next, with Jiri's ack from the other thread [1], thanks for the reviews and acks. BR, Jani. [1] http://lore.kernel.org/r/nycvar.YFH.7.76.1912080106260.4603@xxxxxxxxxxxxx > --- > drivers/hid/hid-picolcd_fb.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/hid/hid-picolcd_fb.c b/drivers/hid/hid-picolcd_fb.c > index e162a668fb7e..a549c42e8c90 100644 > --- a/drivers/hid/hid-picolcd_fb.c > +++ b/drivers/hid/hid-picolcd_fb.c > @@ -417,8 +417,7 @@ static int picolcd_set_par(struct fb_info *info) > return 0; > } > > -/* Note this can't be const because of struct fb_info definition */ > -static struct fb_ops picolcdfb_ops = { > +static const struct fb_ops picolcdfb_ops = { > .owner = THIS_MODULE, > .fb_destroy = picolcd_fb_destroy, > .fb_read = fb_sys_read, -- Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
