== Series Details == Series: video, drm, etc: constify fbops in struct fb_info (rev2) URL : https://patchwork.freedesktop.org/series/70198/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5109f996a5c8 video: fbdev: atyfb: modify the static fb_ops directly -:21: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #21: FILE: drivers/video/fbdev/aty/atyfb.h:344: +extern int aty_init_cursor(struct fb_info *info, struct fb_ops *atyfb_ops); total: 0 errors, 0 warnings, 1 checks, 44 lines checked d1dd9ad23a85 video: fbdev: mb862xx: modify the static fb_ops directly -:21: CHECK:AVOID_EXTERNS: extern prototypes should be avoided in .h files #21: FILE: drivers/video/fbdev/mb862xx/mb862xxfb.h:92: +extern void mb862xxfb_init_accel(struct fb_info *info, struct fb_ops *fbops, int xres); total: 0 errors, 0 warnings, 1 checks, 56 lines checked c9a3fc359d55 video: fbdev: nvidia: modify the static fb_ops directly -:57: WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12) #57: FILE: drivers/video/fbdev/nvidia/nvidia.c:1169: if (!hwcur) + nvidia_fb_ops.fb_cursor = NULL; total: 0 errors, 1 warnings, 0 checks, 43 lines checked 045da6c271da video: fbdev: uvesafb: modify the static fb_ops directly -:12: WARNING:BAD_SIGN_OFF: Duplicate signature #12: Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> total: 0 errors, 1 warnings, 0 checks, 16 lines checked 89a8b3ad953d video: fbdev: make fbops member of struct fb_info a const pointer 7db4d9e5a7ae drm: constify fb ops across all drivers 70ac7fa0dc3d video: fbdev: intelfb: use const pointer for fb_ops aa0f9fd709a6 video: constify fb ops across all drivers c37885d39521 HID: picoLCD: constify fb ops d5cc24c141ca media: constify fb ops across all drivers 4700338b3b91 samples: vfio-mdev: constify fb ops b4c9b961101f auxdisplay: constify fb ops _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx