Re: [v2] drm/i915/perf: Reverse a ternary to make sparse happy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 01, 2019 at 07:21:16PM +0000, Chris Wilson wrote:
> Avoid
> 
> drivers/gpu/drm/i915/i915_perf.c:2442:85: warning: dubious: x | !y
> 
> simply by inverting the predicate and reversing the ternary.
> 
> v2: More the long lines into their own function so there is no confusion
> on operator precedence.
> 
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@xxxxxxxxx>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@xxxxxxxxx>

I don't see this applied to drm-intel yet (unless I am blind) and clang
warns about this as well.

Reviewed-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx




[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux