Hi, On Fri, 22 Nov 2019, Ville Syrjälä wrote: > > - if (IS_G4X(dev_priv) || port == PORT_A) > > + if (IS_G4X(dev_priv) || (INTEL_GEN(dev_priv) < 12 && port == PORT_A)) > > Getting a bit messy. > > Hoovering that into something like > static bool intel_dp_port_has_audio(struct intel_encoder *encoder); > or > static bool intel_dp_port_has_audio(struct drm_i915_private *dev_priv, enum port port); > might be nice. thanks for the review! I went for the latter option in the v2 I just sent out. Br, Kai
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
