Re: [PATCH] drm/i915/selftests: Shorten infinite wait for sseu

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2019-11-21 at 23:30 +0000, Chris Wilson wrote:
> Use our more regular igt_flush_test() to bind the wait-for-idle and
> error out instead of waiting around forever on critical failure.
> 
> Signed-off-by: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

Yeah, seems like a better approach here. Should we just be passing gt
to that though? Doesn't look like we actually use the private data
outside of that. Of course that's completely unrelated to this change.

Reviewed-by: Stuart Summers <stuart.summers@xxxxxxxxx>

> ---
>  drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> index f1ce5f64b221..e1d8ccd11409 100644
> --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c
> @@ -1168,8 +1168,7 @@ __sseu_finish(const char *name,
>  		igt_spinner_end(spin);
>  
>  	if ((flags & TEST_IDLE) && ret == 0) {
> -		ret = intel_gt_wait_for_idle(ce->engine->gt,
> -					     MAX_SCHEDULE_TIMEOUT);
> +		ret = igt_flush_test(ce->engine->i915);
>  		if (ret)
>  			return ret;
>  

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Index of Archives]     [AMD Graphics]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux