On Thu, Nov 21, 2019 at 9:26 AM Timo Aaltonen <tjaalton@xxxxxxxxxx> wrote: > > On 9.10.2019 18.50, Daniel Vetter wrote: > > On Thu, Oct 03, 2019 at 11:31:25AM -0700, Juston Li wrote: > >> From: Daniel Stone <daniels@xxxxxxxxxxxxx> > >> > >> getfb2 allows us to pass multiple planes and modifiers, just like addfb2 > >> over addfb. > >> > >> Changes since v1: > >> - unused modifiers set to 0 instead of DRM_FORMAT_MOD_INVALID > >> - update ioctl number > >> > >> Signed-off-by: Daniel Stone <daniels@xxxxxxxxxxxxx> > >> Signed-off-by: Juston Li <juston.li@xxxxxxxxx> > > > > Looks all good from a very quick glance (kernel, libdrm, igt), but where's > > the userspace? Link to weston/drm_hwc/whatever MR good enough. > > -Daniel > > xserver too > > https://lists.x.org/archives/xorg-devel/2018-March/056363.html > > to fix > > https://gitlab.freedesktop.org/xorg/xserver/issues/33 > > which forces Ubuntu to disable CCS compression, and I'd like to get rid > of that patch. > > Thanks Juston for pushing this! Acked-by: Daniel Vetter <daniel.vetter@xxxxxxxx> ... but someone needs to review all the patches and make sure kernel patch + igt work and pass intel CI and then push it all, and given the pile of committers we have that's not me I think. Just in case people expect me to push this forward, I only jumped in here to make sure new uapi is done by the book and checks all the boxes. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
