On 20/11/2019 16:12, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2019-11-20 16:07:14)
On 20/11/2019 15:21, Chris Wilson wrote:
Before we remove from the timeline, finish flushing the context state.
As the timeline may be peeked upon by another CPU, we don't want to
remove request from the timeline until we have finished working on it.
I have to ask why I'm afraid.
It's the alternative idea to patch 1. If we reorder the code in the
retire, the sanity checks in patch 1 won't notice the inconsistent
state. I think patch 1 is the better expression: if you are dependent on
seeing the post-retirement state, you should wait until that after
retiring.
Yes I agree. This patch had me completely puzzled who could relying on
such subtleties.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
