On Wed, 2019-11-20 at 12:23 +0200, Ville Syrjälä wrote: > On Tue, Nov 19, 2019 at 04:45:05PM -0800, Stuart Summers wrote: > > Platforms without display do not map the MCHBAR MMIO into the GFX > > device BAR. Skip this sequence when display is not available. > > Slightly odd decision to hide this stuff in hw, but fine by me > since we need this only for display bandwidth/watermark stuff. > > Reviewed-by: Ville Syrjälä <ville.syrjala@xxxxxxxxxxxxxxx> Yeah, although there could be other implications to leaving this out depending on the hardware implementation. Thanks for the review here Ville! -Stuart > > > > > Signed-off-by: Stuart Summers <stuart.summers@xxxxxxxxx> > > --- > > drivers/gpu/drm/i915/i915_drv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_drv.c > > b/drivers/gpu/drm/i915/i915_drv.c > > index 8d7049792d62..f509d826fcc7 100644 > > --- a/drivers/gpu/drm/i915/i915_drv.c > > +++ b/drivers/gpu/drm/i915/i915_drv.c > > @@ -1052,7 +1052,7 @@ intel_get_dram_info(struct drm_i915_private > > *dev_priv) > > */ > > dram_info->is_16gb_dimm = !IS_GEN9_LP(dev_priv); > > > > - if (INTEL_GEN(dev_priv) < 9) > > + if (INTEL_GEN(dev_priv) < 9 || !HAS_DISPLAY(dev_priv)) > > return; > > > > if (IS_GEN9_LP(dev_priv)) > > -- > > 2.22.0 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@xxxxxxxxxxxxxxxxxxxxx > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx > >
Attachment:
smime.p7s
Description: S/MIME cryptographic signature
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx