Hi Chris, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on next-20191118] [cannot apply to v5.4-rc8] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify the base tree in git format-patch, please see https://stackoverflow.com/a/37406982] url: https://github.com/0day-ci/linux/commits/Chris-Wilson/drm-i915-gt-Schedule-request-retirement-when-submission-idles/20191119-023819 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-e002-20191119 (attached as .config) compiler: gcc-7 (Debian 7.4.0-14) 7.4.0 reproduce: # save the attached .config to linux build tree make ARCH=i386 If you fix the issue, kindly add following tag Reported-by: kbuild test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): In file included from include/linux/export.h:42:0, from include/linux/linkage.h:7, from include/linux/kernel.h:8, from include/linux/interrupt.h:6, from drivers/gpu/drm/i915/gt/intel_lrc.c:134: drivers/gpu/drm/i915/gt/intel_lrc.c: In function 'execlists_submission_tasklet': drivers/gpu/drm/i915/gt/intel_lrc.c:2235:7: error: implicit declaration of function 'execlists_execlists'; did you mean 'execlists_active'? [-Werror=implicit-function-declaration] if (!execlists_execlists(&engine->execlists)) ^ include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var' #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) ^~~~ >> drivers/gpu/drm/i915/gt/intel_lrc.c:2235:2: note: in expansion of macro 'if' if (!execlists_execlists(&engine->execlists)) ^~ cc1: some warnings being treated as errors vim +/if +2235 drivers/gpu/drm/i915/gt/intel_lrc.c 2205 2206 /* 2207 * Check the unread Context Status Buffers and manage the submission of new 2208 * contexts to the ELSP accordingly. 2209 */ 2210 static void execlists_submission_tasklet(unsigned long data) 2211 { 2212 struct intel_engine_cs * const engine = (struct intel_engine_cs *)data; 2213 bool timeout = preempt_timeout(engine); 2214 2215 process_csb(engine); 2216 if (!READ_ONCE(engine->execlists.pending[0]) || timeout) { 2217 unsigned long flags; 2218 2219 spin_lock_irqsave(&engine->active.lock, flags); 2220 __execlists_submission_tasklet(engine); 2221 spin_unlock_irqrestore(&engine->active.lock, flags); 2222 2223 /* Recheck after serialising with direct-submission */ 2224 if (timeout && preempt_timeout(engine)) 2225 preempt_reset(engine); 2226 } 2227 2228 /* 2229 * If the GPU is currently idle, retire the outstanding completed 2230 * requests. This will allow us to enter soft-rc6 as soon as possible, 2231 * albeit at the cost of running the retire worker much more frequently 2232 * (over the entire GT not just this engine) and emitting more idle 2233 * barriers (i.e. kernel context switches) which may some extra latency. 2234 */ > 2235 if (!execlists_execlists(&engine->execlists)) 2236 intel_gt_schedule_retire_requests(engine->gt); 2237 } 2238 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx Intel Corporation
Attachment:
.config.gz
Description: application/gzip
_______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx
