== Series Details == Series: Add support for mipi dsi cmd mode (rev2) URL : https://patchwork.freedesktop.org/series/69290/ State : warning == Summary == $ dim checkpatch origin/drm-tip fdc21d81bb9e drm/i915/dsi: Configure transcoder operation for command mode. -:60: CHECK:BRACES: braces {} should be used on all arms of this statement #60: FILE: drivers/gpu/drm/i915/display/icl_dsi.c:988: + if (enable) { [...] + } else [...] -:63: CHECK:BRACES: Unbalanced braces around else statement #63: FILE: drivers/gpu/drm/i915/display/icl_dsi.c:991: + } else total: 0 errors, 0 warnings, 2 checks, 82 lines checked 14ef58b82e3d drm/i915/dsi: Add vblank calculation for command mode -:41: WARNING:LONG_LINE: line over 100 characters #41: FILE: drivers/gpu/drm/i915/display/icl_dsi.c:860: + line_time_us = (htotal * (bpp / 8) * byte_clk_period_ns) / (1000 * intel_dsi->lane_count); total: 0 errors, 1 warnings, 0 checks, 73 lines checked efeb2e076cc1 drm/i915/dsi: Add cmd mode flags in display mode private flags -:30: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #30: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:664: +#define I915_MODE_FLAG_DSI_USE_TE0 (1<<3) ^ -:32: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #32: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:666: +#define I915_MODE_FLAG_DSI_USE_TE1 (1<<4) ^ -:34: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV) #34: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:668: +#define I915_MODE_FLAG_DSI_PERIODIC_CMD_MODE (1<<5) ^ total: 0 errors, 0 warnings, 3 checks, 16 lines checked ef45ca1a8eed drm/i915/dsi: Add check for periodic command mode 41fd924cda49 drm/i915/dsi: Use private flags to indicate TE in cmd mode 6222c0176bcb drm/i915/dsi: Configure TE interrupt for cmd mode c61d2184cd7b drm/i915/dsi: Add TE handler for dsi cmd mode. 8d1db9bddfa7 drm/i915/dsi: Initiate fame request in cmd mode _______________________________________________ Intel-gfx mailing list Intel-gfx@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/intel-gfx